RichMapFunction setup method

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RichMapFunction setup method

Mikhail Pryakhin-2
Hi all!

A RichMapFunction [1] provides a very handy setup method RichFunction#open(org.apache.flink.configuration.Configuration) which consumes a Configuration instance as an argument, but this argument doesn't bear any configuration parameters because it is always passed to the method as a new instance. [2] depicts the problem.

Is there any way to pass configuration parameters to the  RichFunction#open method via the Configuration parameter? Or is it a bug?
P.S. I'm using flink 1.3

Thanks in advance!


Kind Regards,
Mike Pryakhin










smime.p7s (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RichMapFunction setup method

Chesnay Schepler
The existing signature for open() is a remnant of the past.

We currently recommend to pass all arguments through the constructor and store them in fields.
You can of course also pass a Configuration containing all parameters.

On 13.06.2017 15:46, Mikhail Pryakhin wrote:
Hi all!

A RichMapFunction [1] provides a very handy setup method RichFunction#open(org.apache.flink.configuration.Configuration) which consumes a Configuration instance as an argument, but this argument doesn't bear any configuration parameters because it is always passed to the method as a new instance. [2] depicts the problem.

Is there any way to pass configuration parameters to the  RichFunction#open method via the Configuration parameter? Or is it a bug?
P.S. I'm using flink 1.3

Thanks in advance!


Kind Regards,
Mike Pryakhin










Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RichMapFunction setup method

Mikhail Pryakhin-2
Hi Chesnay,
Thanks for the reply,

The existing signature for open() is a remnant of the past.

Should the method be deprecated then so that it doesn’t confuse users?

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 16:54, Chesnay Schepler <[hidden email]> wrote:

The existing signature for open() is a remnant of the past.

We currently recommend to pass all arguments through the constructor and store them in fields.
You can of course also pass a Configuration containing all parameters.

On 13.06.2017 15:46, Mikhail Pryakhin wrote:
Hi all!

A RichMapFunction [1] provides a very handy setup method RichFunction#open(org.apache.flink.configuration.Configuration) which consumes a Configuration instance as an argument, but this argument doesn't bear any configuration parameters because it is always passed to the method as a new instance. [2] depicts the problem.

Is there any way to pass configuration parameters to the  RichFunction#open method via the Configuration parameter? Or is it a bug?
P.S. I'm using flink 1.3

Thanks in advance!


Kind Regards,
Mike Pryakhin












smime.p7s (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RichMapFunction setup method

Chesnay Schepler
I'm not aware of any plans to replace it.

For the Batch API it also works properly, so deprecating it would be misleading.

On 13.06.2017 16:04, Mikhail Pryakhin wrote:
Hi Chesnay,
Thanks for the reply,

The existing signature for open() is a remnant of the past.

Should the method be deprecated then so that it doesn’t confuse users?

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 16:54, Chesnay Schepler <[hidden email]> wrote:

The existing signature for open() is a remnant of the past.

We currently recommend to pass all arguments through the constructor and store them in fields.
You can of course also pass a Configuration containing all parameters.

On 13.06.2017 15:46, Mikhail Pryakhin wrote:
Hi all!

A RichMapFunction [1] provides a very handy setup method RichFunction#open(org.apache.flink.configuration.Configuration) which consumes a Configuration instance as an argument, but this argument doesn't bear any configuration parameters because it is always passed to the method as a new instance. [2] depicts the problem.

Is there any way to pass configuration parameters to the  RichFunction#open method via the Configuration parameter? Or is it a bug?
P.S. I'm using flink 1.3

Thanks in advance!


Kind Regards,
Mike Pryakhin












Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RichMapFunction setup method

Mikhail Pryakhin-2
Thanks a lot  Chesnay,

In case it works properly in the Batch API, don’t you think that it should not be called "remnant of the past“?
Should I create an issue so we don’t forget about it and may be fix it in the future, I think I’m not the only one who deals with this method.

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 17:20, Chesnay Schepler <[hidden email]> wrote:

I'm not aware of any plans to replace it.

For the Batch API it also works properly, so deprecating it would be misleading.

On 13.06.2017 16:04, Mikhail Pryakhin wrote:
Hi Chesnay,
Thanks for the reply,

The existing signature for open() is a remnant of the past.

Should the method be deprecated then so that it doesn’t confuse users?

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 16:54, Chesnay Schepler <[hidden email]> wrote:

The existing signature for open() is a remnant of the past.

We currently recommend to pass all arguments through the constructor and store them in fields.
You can of course also pass a Configuration containing all parameters.

On 13.06.2017 15:46, Mikhail Pryakhin wrote:
Hi all!

A RichMapFunction [1] provides a very handy setup method RichFunction#open(org.apache.flink.configuration.Configuration) which consumes a Configuration instance as an argument, but this argument doesn't bear any configuration parameters because it is always passed to the method as a new instance. [2] depicts the problem.

Is there any way to pass configuration parameters to the  RichFunction#open method via the Configuration parameter? Or is it a bug?
P.S. I'm using flink 1.3

Thanks in advance!


Kind Regards,
Mike Pryakhin














smime.p7s (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RichMapFunction setup method

Chesnay Schepler
It is a remnant of the past since that method signature originates from the Record API,
the predecessor of the current DataSet API.

Even in the DataSet API you can just pass arguments through the constructor.
Feel free to open a JIRA, just make sure it is a subtask of FLINK-3957.

On 13.06.2017 16:40, Mikhail Pryakhin wrote:
Thanks a lot  Chesnay,

In case it works properly in the Batch API, don’t you think that it should not be called "remnant of the past“?
Should I create an issue so we don’t forget about it and may be fix it in the future, I think I’m not the only one who deals with this method.

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 17:20, Chesnay Schepler <[hidden email]> wrote:

I'm not aware of any plans to replace it.

For the Batch API it also works properly, so deprecating it would be misleading.

On 13.06.2017 16:04, Mikhail Pryakhin wrote:
Hi Chesnay,
Thanks for the reply,

The existing signature for open() is a remnant of the past.

Should the method be deprecated then so that it doesn’t confuse users?

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 16:54, Chesnay Schepler <[hidden email]> wrote:

The existing signature for open() is a remnant of the past.

We currently recommend to pass all arguments through the constructor and store them in fields.
You can of course also pass a Configuration containing all parameters.

On 13.06.2017 15:46, Mikhail Pryakhin wrote:
Hi all!

A RichMapFunction [1] provides a very handy setup method RichFunction#open(org.apache.flink.configuration.Configuration) which consumes a Configuration instance as an argument, but this argument doesn't bear any configuration parameters because it is always passed to the method as a new instance. [2] depicts the problem.

Is there any way to pass configuration parameters to the  RichFunction#open method via the Configuration parameter? Or is it a bug?
P.S. I'm using flink 1.3

Thanks in advance!


Kind Regards,
Mike Pryakhin














Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RichMapFunction setup method

Mikhail Pryakhin-2
Hi Chesnay,

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 21:47, Chesnay Schepler <[hidden email]> wrote:

It is a remnant of the past since that method signature originates from the Record API,
the predecessor of the current DataSet API.

Even in the DataSet API you can just pass arguments through the constructor.
Feel free to open a JIRA, just make sure it is a subtask of FLINK-3957.

On 13.06.2017 16:40, Mikhail Pryakhin wrote:
Thanks a lot  Chesnay,

In case it works properly in the Batch API, don’t you think that it should not be called "remnant of the past“?
Should I create an issue so we don’t forget about it and may be fix it in the future, I think I’m not the only one who deals with this method.

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 17:20, Chesnay Schepler <[hidden email]> wrote:

I'm not aware of any plans to replace it.

For the Batch API it also works properly, so deprecating it would be misleading.

On 13.06.2017 16:04, Mikhail Pryakhin wrote:
Hi Chesnay,
Thanks for the reply,

The existing signature for open() is a remnant of the past.

Should the method be deprecated then so that it doesn’t confuse users?

Kind Regards,
Mike Pryakhin


On 13 Jun 2017, at 16:54, Chesnay Schepler <[hidden email]> wrote:

The existing signature for open() is a remnant of the past.

We currently recommend to pass all arguments through the constructor and store them in fields.
You can of course also pass a Configuration containing all parameters.

On 13.06.2017 15:46, Mikhail Pryakhin wrote:
Hi all!

A RichMapFunction [1] provides a very handy setup method RichFunction#open(org.apache.flink.configuration.Configuration) which consumes a Configuration instance as an argument, but this argument doesn't bear any configuration parameters because it is always passed to the method as a new instance. [2] depicts the problem.

Is there any way to pass configuration parameters to the  RichFunction#open method via the Configuration parameter? Or is it a bug?
P.S. I'm using flink 1.3

Thanks in advance!


Kind Regards,
Mike Pryakhin
















smime.p7s (2K) Download Attachment
Loading...